Jack (W8TEE):
Taking a gander at the source code, I noticed several potential macro gotchas in SDT.h (SDTVer049.1).? For example:
#define INCREMENT_X? ? ? ? ? ?WATERFALL_RIGHT_X + 25
should be
#define INCREMENT_X? ? ? ? ? ?(WATERFALL_RIGHT_X + 25)
Without parentheses around the sum, if someone tries multiplying or dividing, by anything other than unity, an erroneous result will ensue (divide by zero notwithstanding).? Attached is a diff file with the corrections to the other macros, which are not that many.? Hopefully, these changes won't break anything ;)
Also, is there a better way to submit changes, like a github project page, to make submitting and merging changes easier?
Cheers,
Ian
ian007